Closed fremail closed 5 years ago
Hi @fremail, thanks for your contribution!
Can you please sync merge from master so the Travis CI build will pass?
Also, I have the following doubts:
cleanse
is in index.js, why there's a new parameter to the function? If this is the only usage, it should be the default behavior.\s
will be better? (e.g. [ \t\r\f]
)test_ssml.js
? As the real change happens in a function related to to-ssml.js
, I think the tests should occur there.I think it's time we close this 2 years old issue :)
@kobim my answers
I didn't change the original changes had been made in PR #83, but actually I agree with you: I don't see any reason in adding new param to the function.
Oh, it's a good catch! Thank you for finding that bug in the change. I'll work to fix it.
Really good question! I don't know why I did so :D
LGTM! I'll merge it to the master and will it will be released along with 4.2.3 (hopefully along with #378) this weekend.
Thanks again!
See PR #83 (2 years old hehe)
I merged the changes to current code and added tests.