alexa-js / alexa-app

A framework for Alexa (Amazon Echo) apps using Node.js
https://www.youtube.com/watch?v=pzM4jv7k7Rg
MIT License
1.03k stars 212 forks source link

Implement CanFulfillIntent #375

Closed orlylev closed 5 years ago

orlylev commented 5 years ago

Implement CanFulfillIntent

  1. Add request handler for CanFulfillIntent
  2. Add default response with 'No' for the intents and slots in the requests This will be created automatically when for CanFulfillIntent request
  3. Add API to set the values of the intents and slots
  4. Change user parsing to enable working without the user object (requested by Amazon) Regards Amazon Alexa details: https://developer.amazon.com/docs/custom-skills/implement-canfulfillintentrequest-for-name-free-interaction.html https://developer.amazon.com/docs/custom-skills/understand-name-free-interaction-for-custom-skills.html Orly
kobim commented 5 years ago

Hi @orlylev, thanks for your contribution! Before I dive into the code, could you please make sure the following requirements are met:

  1. add tests for your code - although this is a new code and it doesn't touch any existing API, we still need to make sure it's tested before we merge.
  2. sync merge from master (there's a fix for the failing builds).
  3. (minor issue) move your contribution line (CHANGELOG.md) to the last line instead of the first.

Once the changes are applied, I'll start the review and we will try to merge this as soon as possible.