alexa-js / alexa-app

A framework for Alexa (Amazon Echo) apps using Node.js
https://www.youtube.com/watch?v=pzM4jv7k7Rg
MIT License
1.03k stars 212 forks source link

chore: upgrade the entire dev environment #394

Closed favna closed 5 years ago

favna commented 5 years ago

This library was in strong need of this, especially examplified by the amount of security vulnerabilities before upgrading:

npm i
added 404 packages from 865 contributors and audited 2672 packages in 8.639s
found 462 vulnerabilities (150 low, 12 moderate, 299 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

and after:

yarn install --audit
yarn install v1.17.3
[1/6] �🔍  Validating package.json...
[2/6] �🔍  Resolving packages...
[3/6] �🔍  Auditing packages...
[4/6] �🚚  Fetching packages...
info fsevents@1.2.9: The platform "win32" is incompatible with this module.
info "fsevents@1.2.9" is an optional dependency and failed compatibility check. Excluding it from installation.
[5/6] �🔗  Linking dependencies...
[6/6] �🔨  Building fresh packages...
0 vulnerabilities found - Packages audited: 885806
✨  Done in 3.70s.

So here's what I did in short:

Coverage report: https://hasteb.in/docunodu.sh Sidenote that coverage report didn't work on Windows because Istanbul has some parsing issue with the _mocha.cmd file which gets called on it. Works just fine on Linux / MacOS though which should be no problem because Travis is using Ubunutu.


@dblock been a while btw hasn't it ;) decided to rewrite my alexa skill to TS as it's one of my last JS based things and I stumbled on all of this.

dblock commented 5 years ago

Quick question: do we have to drop node.js support < 10 here? What desn't work?

lazerwalker commented 5 years ago

+1, I'm okay with all of this.

favna commented 5 years ago

@dblock 6 or 8 might even be possible but for one I removed bluebird and instead opting for NodeJS's internal promises. But the reason I went for 10 is because anything below is EOL and won't get security updates anymore.

And it wouldn't exactly be fitting if somehow at some point an exploit would arise in an Alexa skill and it turns out that it's because alexa-app supports insecure legacy code.

dblock commented 5 years ago

@Favna See my edits for UPGRADING, I'll merge after that change. Thank you.

favna commented 5 years ago

done @dblock :) !

dblock commented 5 years ago

Merged, thank you!