Closed favna closed 5 years ago
Quick question: do we have to drop node.js support < 10 here? What desn't work?
+1, I'm okay with all of this.
@dblock 6 or 8 might even be possible but for one I removed bluebird and instead opting for NodeJS's internal promises. But the reason I went for 10 is because anything below is EOL and won't get security updates anymore.
And it wouldn't exactly be fitting if somehow at some point an exploit would arise in an Alexa skill and it turns out that it's because alexa-app supports insecure legacy code.
@Favna See my edits for UPGRADING, I'll merge after that change. Thank you.
done @dblock :) !
Merged, thank you!
This library was in strong need of this, especially examplified by the amount of security vulnerabilities before upgrading:
and after:
So here's what I did in short:
Upgraded minimum NodeJS to current LTS, v10
Upgraded all dependencies to their latest possible versions
Replaced pre-babel-7 packages with their babel-7 equivalents
Installed additional @types libraries for VSCode / other IDE IntelliSesne
Rewrote eslintrc to JSON which is the standard format and is easier to modify
Filtered out package-lock, allowed yarn.lock.
Configured travis to use yarn for more optimal caching
Filtered out all log files, not just npm-debug.log
Renamed all test to the *.spec.js pattern, a common test pattern
Fixed 3 tests that were failing on upgraded Chai code
Linting galore
Created a "files" field in package.json, so the publish to NPM doesn't have all the unnecessary files.
90f9856cdf31d430047d7e119d4f1fcbd4df1e9d adds slightly better typings
response.slot()
which now allows structures such as these where the slotName gets limited to the type / enum that is supplied. This is a slight bit more type safety.Bumped to version 5.0.0. THIS IS IMPORTANT. This change entirely includes BREAKING CHANGES and is likely NOT backwards compatible, especially due to the NodeJS bump from v1 to v10. People who still use Node version < 10 can continue to use v4.3.0, but anyone else should be able to upgrade.
Coverage report: https://hasteb.in/docunodu.sh Sidenote that coverage report didn't work on Windows because Istanbul has some parsing issue with the
_mocha.cmd
file which gets called on it. Works just fine on Linux / MacOS though which should be no problem because Travis is using Ubunutu.@dblock been a while btw hasn't it ;) decided to rewrite my alexa skill to TS as it's one of my last JS based things and I stumbled on all of this.