search

alexa-js / alexa-utterances

generate expanded utterances for Amazon Alexa from a template string
MIT License
152 stars 28 forks source link

Support for custom slot types using curly braces while retaining backward compatibility #9

Closed rickwargo closed 8 years ago

rickwargo commented 8 years ago

Modified previous approach to have it be backwards compatible and support parens for grouping and alternation and curly braces for custom slot names.

Modified tests where appropriate to use parens for grouping. Added additional tests to use curly braces for grouping. Added test for new approach custom slot type.

Also supports use of {-|Name} and {Name} for custom slots.

Note: does not support nested groups - will open issue and work on pull request for that.

mreinstein commented 8 years ago

hi @rickwargo, looks good! Can you please submit the PR to the 1.0 branch instead of master?

I'm going to wait a little while before publishing alexa-utterances@1.0 in case any small issues come up in the short term and have to push patches.

thanks man!

rickwargo commented 8 years ago

oops, @mreinstein. Will do.