Refactored tests and added coverage support

alexa-js / alexa-verifier-middleware

An express middleware that verifies HTTP requests sent to an Alexa skill are sent from Amazon.

MIT License

31 stars 6 forks source link

Refactored tests and added coverage support #13

Closed tejashah88 closed 7 years ago

dblock commented 7 years ago

Note that in https://github.com/alexa-js/alexa-app/pull/145#issuecomment-277483077 @mreinstein is saying that the change that makes the verifier only check POST is not a good idea. Whichever way the cookie crumbles I think there should be an explicit test for that (eg. that a GET is verified if the change here is reverted).

dblock commented 7 years ago

Fair enough, i added it to Travis (you can do these things too @tejashah88) and it worked.

dblock commented 7 years ago

This looks good to me, feel free to merge.

coveralls commented 7 years ago

Changes Unknown when pulling 3483828bc062e53e4877f9bcff7b7993cc1d1b7b on tejashah88:master into on alexa-js:master.

tejashah88 commented 7 years ago

We should probably disable the coveralls bot from spamming coverage updates.

dblock commented 7 years ago

I removed comments on PRs from https://coveralls.io/github/alexa-js/alexa-verifier-middleware.