search

alexa-js / alexa-verifier-middleware

An express middleware that verifies HTTP requests sent to an Alexa skill are sent from Amazon.
MIT License
31 stars 6 forks source link

validator update from 9.0.0 to 13.7.0 #52

Closed Reni88 closed 9 months ago

Reni88 commented 10 months ago

Remediates CVE-2021-3765

tejashah88 commented 10 months ago

@mreinstein I've noticed that I don't see the CI action workflow executing when new PRs are made. Is this intentional?

mreinstein commented 10 months ago

Currently it only runs on pushes to themaster branch: https://github.com/alexa-js/alexa-verifier-middleware/blob/417f4ebfd3f1513f5c9b2b2e81dc637ccc735361/.github/workflows/main.yml#L7-L9

mreinstein commented 10 months ago

I've updated the workflow to run on PR activity now.

Reni88 commented 10 months ago

Hello. Hoping someone is already reviewing this PR.

dblock commented 10 months ago

@Reni88 can you please rebase so we can see CI/CD kick after @mreinstein's fix of the workflow file?

tejashah88 commented 9 months ago

@dblock LGTM! You may merge when ready.

dblock commented 9 months ago

@tejashah88 you too :)

Reni88 commented 9 months ago

As this is merged, @tejashah88 or @dblock , when can we expect it'll be updated in npmjs?