Closed y-nk closed 7 years ago
Hey! Thanks for the idea. From a brief look it makes sense. Have you thought about how this would work with #52?
Couple of observations:
indicate_crashing_*
- it doesn't really mean something is crashingindicate_muting_*
- muting? this brings association with mic mutingindicate_greeting_*
and indicate_awaking_*
you lose the indication of playback for hello and yes if I'm correct ... I don't have an opinion on if this is okay or notI do agree crashing might be the best verb to define "a dead end because of server failure".
You are right about muting, maybe then idling would be better ?
I do understand your concern about the other terms ; maybe it's all about finding the best verbs ; as for "awaking", my team and I described this phase that way because the real amazon echo does not speak while turning awake, rather emit a beep sound.
I'd be glad to implement it the way of #52 if more people like it this way ; I honestly didn't look at it before, and proposed simple callback fashion by personal preference.
@ynk Any work on AlexaPi is appreciated, so if you like to, knock yourself out :smile:
@renekliment thank you. I've done a lot of work during the 2 last days. I'll submit my PR tonight hopefully.
Hi,
First of all, thanks for the amazing work. I kickstarted my project in seconds. As I work with Alexa for quite some time now, I found myself struggling while dealing with the
indicate
callbacks provided in devices ; sure enough, I made my own implementation to fit the need of our project, but still.I'd like to propose to make steps of talking with Alexa more granular, not only by giving booleans as arguments, but by providing hooks reflecting the real lifecycle of a conversation with Alexa. The terminology I chose in my proposal is toward something more human-like in the lifecycle, which make sens to me as we deal with a VUi.
For now, and as far as i traced it, here's the current lifecycle :
I would propose the following :
This is totally open to discussion, and in case of approval I would do my best to fill a proper PR with documentation.
Thanks, J.