search

alexa-samples / skill-sample-nodejs-audio-player

An Alexa Skill Sample showing how to play long form audio in 3P-skills
Other
470 stars 319 forks source link

Reorder #53

Open JakeMKelly opened 7 years ago

JakeMKelly commented 7 years ago

@sleepydeveloper

sebsto commented 6 years ago

Hello @JakeMKelly

Thank you for proposing all these changes and improving the documentation. Unfortunately, there are a lot of merge conflicts since you submitted this PR.

Would you mind considering sending smaller PRs that we can easily merge to the main branch ?
I would suggest a/ to make distinct PR for the multi stream and single stream example b/ do not rename directories on the single stream project (I know I am not respecting the default for ASK CLI but it matches the default structure of VSCode :-) ) c/ make distinct PRs for doc and code change.

I really appreciate the extra doc you wrote and the ASK CLI migration effort and would love to have these included in the main repo.

Let me know how best you think we can move forward.