search

alexa-samples / skill-sample-nodejs-quiz-game

An Alexa Skill Sample showing how to build a quiz game skill.
Other
265 stars 289 forks source link

Few warnings #22

Closed Veiam closed 5 years ago

Veiam commented 6 years ago

Hello all,

In index.js

Line 54 return "The " + formatCasing(property) + " of " + item.StateName + " is <say-as interpret-as='spell-out'>" + item[property] + "</say-as>. " and Line 57 return "The " + formatCasing(property) + " of " + item.StateName + " is " + item[property] + ". " are missing a semicolon at the end.

Also since return is being performed on 54 and 57, 55 and 58's break is unreachable I believe.

Line 294 let property = this.attributes["quizproperty"] is also missing a semicolon at the end.

Line 176 const counter = 0; Line 374 'function getRandomSymbolSpeech(symbol)' Line 404 let speechCon = ""; These all three are defined but never used within the js. Is this intended?

franklin-lobb commented 5 years ago

Thanks for pointing these out. I've double-checked the current code and it looks like these have all been fixed.