Add abstraction layer over servlet interface when calling Verifiers

kkocel commented 5 years ago

Description

Providing interface over HttpServletRequest in order to use verifiers non-servlet contexts - like reactive solutions, gateways etc.

Motivation and Context

Currently it's impossible to use validators without servlet API. After the change it's possible to create other implementations of Request like ReactiveRequest etc.

Testing

All existing test cases cover refactored code.

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[ ] I have read the README document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

kkocel commented 5 years ago

@breedloj would you mind taking a look? :)

breedloj commented 5 years ago

Hey Christopher, sorry for the delayed review. Thanks for the PR! I like this change. Had a small comment regarding naming but that aside it looks good to me.

breedloj commented 5 years ago

Changes look good and will be included in the next release of the SDK. Thanks again!

kkocel commented 5 years ago

@breedloj what is rough estimation for release?

breedloj commented 5 years ago

This was released as part of 2.20.2.

alexa / alexa-skills-kit-sdk-for-java