alexa / alexa-skills-kit-sdk-for-java

The Alexa Skills Kit SDK for Java helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.
http://developer.amazon.com/ask
Apache License 2.0
817 stars 747 forks source link

Use sjlf4j-api instead of impl in SDK #300

Closed kkocel closed 2 years ago

kkocel commented 2 years ago

Use log4j-slf4j-impl in samples in tests. Logging instructtions in the Readme.md

Fixes #271

Types of changes

Checklist

License

kkocel commented 2 years ago

@Shreyas-vgr so it's good to merge?

SCKelemen commented 2 years ago

Maybe this should be prioritized: https://www.lunasec.io/docs/blog/log4j-zero-day/

kkocel commented 2 years ago

@SCKelemen yes, I bumped dependencies to fix this 0 day, @Shreyas-vgr another reason for the merge :)

Fortunately, my PR removes log4j impl from the production code so log4j won't be added into the user codebase.

htmldoug commented 2 years ago

@ShenChen93, sorry for the direct tag, but given the severity, can you please help get this merged and released?

Shreyas-vgr commented 2 years ago

Merged the change to mainline, thanks @kkocel for the PR