alexa / alexa-skills-kit-sdk-for-java

The Alexa Skills Kit SDK for Java helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.
http://developer.amazon.com/ask
Apache License 2.0
816 stars 746 forks source link

missing assertions on unit tests #332

Open sayantandey opened 1 year ago

sayantandey commented 1 year ago

Description

Dummy PR to show that JUnits in PR pipeline tests will pass even after changing the logic. Missing unit test assertions for RequestResponseUtils

Module : ask-sdk-local-debug

This pull request shows even with modified code logic , the unit tests pass.

I have modified some logics in this utils to show that assertions are not sufficient.

This issue might be found in other modules, need to be checked.

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

sayantandey commented 1 year ago

This is a dummy PR to show that tests in the pipeline will pass even after code logic is removed and changed. Don't merge. Thanks