Open sayantandey opened 1 year ago
Dummy PR to show that JUnits in PR pipeline tests will pass even after changing the logic. Missing unit test assertions for RequestResponseUtils
RequestResponseUtils
ask-sdk-local-debug
This pull request shows even with modified code logic , the unit tests pass.
I have modified some logics in this utils to show that assertions are not sufficient.
This issue might be found in other modules, need to be checked.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
Additional assertions required
[ ] Breaking change (fix or feature that would cause existing functionality to change)
This is a dummy PR to show that tests in the pipeline will pass even after code logic is removed and changed. Don't merge. Thanks
Description
Dummy PR to show that JUnits in PR pipeline tests will pass even after changing the logic. Missing unit test assertions for
RequestResponseUtils
Module :
ask-sdk-local-debug
This pull request shows even with modified code logic , the unit tests pass.
I have modified some logics in this utils to show that assertions are not sufficient.
This issue might be found in other modules, need to be checked.
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
License