missing assertions on unit tests - Githubissues

alexa / alexa-skills-kit-sdk-for-java

The Alexa Skills Kit SDK for Java helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.

http://developer.amazon.com/ask

Apache License 2.0

815 stars 748 forks source link

missing assertions on unit tests #333

Open sayantandey opened 1 year ago

sayantandey commented 1 year ago

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[x] Other... Please describe:

Issue with Junits missing assertions which might cause the unit tests to miss potential bugs. Missing unit test assertions for ask-sdk-local-debug : RequestResponseUtils

Expected Behavior

One or more unit test assertion should fail after the code's logic is changed.
One or more unit test should cover default switch case

Current Behavior

No assertions error thrown
Missing test for default switch case

Steps to Reproduce (for bugs)

Check out this PR gh pr checkout 332
Run the unit tests by mvn clean test

Possible Solution

Add assertions for method invocation for skillInvokerConfiguration of type SKILL_STREAM_HANDLER_TYPE
Add additional tests for Unknown skill configuration type

Context

Your Environment

ASK Java SDK version used: 1.8
Operating System and version: Microsoft Windows [Version 10.0.19044.2846]

Java Info

Java version used for development: 8