search

alexa / alexa-skills-kit-sdk-for-nodejs

The Alexa Skills Kit SDK for Node.js helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.
Apache License 2.0
3.12k stars 736 forks source link

AWS CodeCommit not compatible to Alexa ASK CLI #550

Closed StefanV85 closed 4 years ago

StefanV85 commented 5 years ago

Hello The AWS CodeCommit Repositorys doesn't have an URL which ends with ".GIT" e.g. https://git-codecommit.eu-west-1.amazonaws.com/v1/repos/XXXX-Alexa-Template

Unfortunately in the ASK CLI is a Check that a Valid GIT URL must end with .GIT Its in ask-cli\lib\utils\url-utils.js Method: isUrlWithGitExtension

If i modify this check, the ASK CLI works very fine with CodeCommit Repositorys. e.g. ask new --url https://git-codecommit.eu-west-1.amazonaws.com/v1/repos/XXXX-Alexa-Template

Would be very fine if someone could fix this issue.

Kind Regards Stefan

RonWang commented 5 years ago

Hi Stefan,

Thanks for posting your usage over this command, I think it's a valid use case. We will investigate how to accept a broader range of URL inputs as well as keeping it secure.

Thanks, Ron

nikhilym commented 4 years ago

Since this issue is related to ASK-CLI, it's better to track it on the CLI repo. @RonWang can you transfer this to the corresponding repo?

StefanV85 commented 4 years ago

is there anything new about this? i updated the ask cli and have again the same problem. but my hack doesn't work anymore. if i change again the url-utils.js the error doesn't apear, but the ask cli is not asking about git credentials... it hangs... and doesn't create my skill.

RonWang commented 4 years ago

@StefanV85 Close this issue and please head over to https://github.com/alexa/ask-cli/issues/269 for further discussion.

kakhaUrigashvili commented 4 years ago

@RonWang opened a PR https://github.com/alexa/ask-cli/pull/273