alexa / alexa-skills-kit-sdk-for-nodejs

The Alexa Skills Kit SDK for Node.js helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.
Apache License 2.0
3.13k stars 738 forks source link

[JUST IDEA][WIP] fix: add tst dir to exexute tslint #587

Closed hideokamoto closed 5 years ago

hideokamoto commented 5 years ago

Description

Ref: tslint dose not check tst dir files #585

How do you think the gulp task definition? If you think OK, I'll fix these tslint error and update another project's gulp files.

Motivation and Context

Testing

Expected

o$ lerna --scope ask-sdk-core run gulp -- tslint
info cli using local version of lerna
lerna notice cli v3.16.4
lerna info filter [ 'ask-sdk-core' ]
lerna info Executing command in 1 package: "npm run gulp tslint"
lerna ERR! npm run gulp tslint exited 1 in 'ask-sdk-core'
lerna ERR! npm run gulp tslint stdout:

> ask-sdk-core@2.7.0 gulp /Users/develop/npm/alexa-skills-kit-sdk-for-nodejs/ask-sdk-core
> gulp "tslint"

[13:06:55] Using gulpfile ~/develop/npm/alexa-skills-kit-sdk-for-nodejs/ask-sdk-core/gulpfile.js
[13:06:55] Starting 'tslint'...

ERROR: tst/util/RequestEnvelopeUtil.spec.ts:24:5 - Named imports must be alphabetized.
ERROR: tst/util/RequestEnvelopeUtil.spec.ts:49:62 - Missing semicolon
ERROR: tst/util/RequestEnvelopeUtil.spec.ts:92:73 - Missing semicolon
ERROR: tst/util/RequestEnvelopeUtil.spec.ts:135:43 - Use the object spread operator instead.
ERROR: tst/util/RequestEnvelopeUtil.spec.ts:135:77 - Missing semicolon
ERROR: tst/util/RequestEnvelopeUtil.spec.ts:136:61 - Missing semicolon

lerna ERR! npm run gulp tslint stderr:

Screenshots (if appropriate)

Types of changes

Checklist

License

ShenChen93 commented 5 years ago

Hi @hideokamoto ,

Thanks for the PR, it's a good solution for me. I made the same change to other packages and fix some lint issues as well in this PR.

Thanks, Shen