BREAKING CHANGE: Redesign SmapiClient class - Githubissues

alexa / alexa-skills-kit-sdk-for-nodejs

The Alexa Skills Kit SDK for Node.js helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.

Apache License 2.0

3.12k stars 737 forks source link

BREAKING CHANGE: Redesign SmapiClient class #597

Closed ShenChen93 closed 4 years ago

ShenChen93 commented 4 years ago

Description

Redesign SmapiClient class for better extensibily to support other auth methods

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs(Add new document content)
[ ] Translate Docs(Translate document content)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed
[x] My commit message follows Conventional Commit Guideline

License

[x] I confirm that this pull request can be released under the Apache 2 license