search

alexa / alexa-skills-kit-sdk-for-nodejs

The Alexa Skills Kit SDK for Node.js helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.
Apache License 2.0
3.12k stars 736 forks source link

ISP customProductPrompts Inconsistency #655

Closed DecathectZero closed 3 years ago

DecathectZero commented 3 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Other... Please describe:

In ask-smapi-model for CustomProductPrompts it is referred to as boughtConfirmationPrompt https://github.com/alexa/alexa-apis-for-nodejs/blob/master/ask-smapi-model/index.ts#L902

but as defined in this schema https://developer.amazon.com/en-US/docs/alexa/smapi/isp-schemas.html it is referred to as boughtCardDescription - this inconsistency is a bit annoying and is it intended?

This causes an error when making a smapi.updateIspForProductV1 or createIspForVendorV1 call and requires the type to be overridden

ShenChen93 commented 3 years ago

Hi @DecathectZero ,

Thanks for reporting this issue. Idealy those two schema should be exactly match, I will reachout to service team and figure out whether we need to update our model to use property name boughtCardDescription. If it's a model issue, we will fix it in next model release.

Thanks, Shen

ShenChen93 commented 3 years ago

Hi @DecathectZero ,

We released a new patch version of SMAPI Model 1.12.2 yesterday which fix this SPI issue. Thus will close this issue for now. Could you please download the latest SMAPI model and see if the issue is fixed. Please feel free to reopen if you still have questions or converns.

Thanks, Shen