feat(aws-sdk-s3-persistence-adapter, aws-sdk-dynamodb-persistence-adapter): upgrade dynamodb and s3 persistence adapters to use AWS SDK v3

alexa / alexa-skills-kit-sdk-for-nodejs

The Alexa Skills Kit SDK for Node.js helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.

Apache License 2.0

3.12k stars 735 forks source link

Open sam-goodwin opened 2 years ago

sam-goodwin commented 2 years ago

This change refactors the S3 and DynamoDB persistence adapters to use AWS SDK v3.

[ ] As this is a breaking change, I also bumped the major version of those libraries to 3.0.0. Is this correct or should it be a minor version bump?
[ ] Update the mocked unit tests. See https://www.npmjs.com/package/aws-sdk-client-mock

paul-uz commented 2 years ago

Does this remove the dependency for the v2 AWS SDK fully, and make it fully v3 compatible?

sam-goodwin commented 2 years ago

Yes, i removed it from s3 and dynamo db adapter packages.

jheym commented 1 year ago

paul-uz commented 1 year ago

Can we get this merged in yet? It's been 2 years...

sam-goodwin commented 1 year ago

Can we get this merged in yet? It's been 2 years...

I no longer work at Amazon, sorry. Hopefully someone from the SDK team can help you out.