Add personId partitionKey generator - Githubissues

alexa / alexa-skills-kit-sdk-for-python

The Alexa Skills Kit SDK for Python helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.

https://developer.amazon.com/en-US/docs/alexa/alexa-skills-kit-sdk-for-python/overview.html

Apache License 2.0

812 stars 206 forks source link

Add personId partitionKey generator #125

Closed nikhilym closed 5 years ago

nikhilym commented 5 years ago

Description

Provide a partition key generator for person id, when person id exists on the request envelope. This is similar to the PR on Java SDK here

Motivation and Context

Java SDK PR.

Testing

Added unit tests.

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

nikhilym commented 5 years ago

Merging this PR since the only diff between earlier revision and this one is the casing, and the earlier ones were approved.