Refactor with ask-smapi-sdk - Githubissues

alexa / ask-cli

Alexa Skills Kit Command Line Interface

https://developer.amazon.com/en-US/docs/alexa/smapi/ask-cli-intro.html

Apache License 2.0

167 stars 55 forks source link

Refactor with ask-smapi-sdk #362

Closed RonWang closed 2 years ago

RonWang commented 3 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request 
[x] Other... Refactor

Expected Behavior

Using ask-smapi-sdk (https://www.npmjs.com/package/ask-smapi-sdk) should be happening in the smapi-client.

Current Behavior

Currently the smapi-client is stored in the code. Relying on ask-smapi-sdk saves us effort to maintain new APIs.

Possible Solution

Notes:

Smapi-sdk doesn't support same existing env var as CLI does. ASK_REFRESH_TOKEN ASK_ACCESS_TOKEN and ASK_CLI_PROXY are all supported settings in current ask-cli. We need to pass those data to smapi-sdk as well
The support for network trace (enabled when --debug is set) should be identical to what we have.

CamdenFoucht commented 2 years ago

Smapi client was refactored in ask-cli-x and will be released in a later cli version.