Re-introducing the changes to use localhost in the redirect URL for LWA authentication, rather than 127.0.0.1.
The changes were initially introduced here and reverted here.
Motivation and Context
This allows the redirect to go through successfully for WSL users.
For context, these changes were introduced in version 2.11.2 of the extension but were backed out, as it caused an issue for new profiles when attempting to authenticate. The redirect URL whitelist in the existing security profile was not configured to allow for localhost:9090. We have since updated the configuration and can move ahead with this change (testing details below).
Testing
Downgraded extension to 2.11.2, where the changes (and localhost redirect failure) were first introduced:
Created a new profile:
Signed in to the LWA portal, redirect URL is now showing localhost and is successful:
We are also getting the success response in VSCode:
Unit tests successful:
Screenshots (if appropriate)
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
Use localhost instead 127.0.0.1 for WSL support
Description
Re-introducing the changes to use localhost in the redirect URL for LWA authentication, rather than 127.0.0.1.
The changes were initially introduced here and reverted here.
Motivation and Context
This allows the redirect to go through successfully for WSL users.
For context, these changes were introduced in version 2.11.2 of the extension but were backed out, as it caused an issue for new profiles when attempting to authenticate. The redirect URL whitelist in the existing security profile was not configured to allow for localhost:9090. We have since updated the configuration and can move ahead with this change (testing details below).
Testing
Downgraded extension to 2.11.2, where the changes (and localhost redirect failure) were first introduced:
Created a new profile:
Signed in to the LWA portal, redirect URL is now showing localhost and is successful:
We are also getting the success response in VSCode:
Unit tests successful:
Screenshots (if appropriate)
Types of changes
Checklist
License