fix: correct AbstractCommand for context menus - Githubissues

alexa / ask-toolkit-for-vscode

ASK Toolkit is an extension for Visual Studio Code (VSC) that that makes it easier for developers to develop and deploy Alexa Skills.

https://developer.amazon.com/en-US/docs/alexa/ask-toolkit/get-started-with-the-ask-toolkit-for-visual-studio-code.html

Apache License 2.0

108 stars 52 forks source link

fix: correct AbstractCommand for context menus #231

Closed tonyhallett closed 1 year ago

tonyhallett commented 1 year ago

Description

Context menu commands do not work.

Motivation and Context

fixes #227 that has been bizarrely closed in favour of a workaround.

Testing

https://github.com/tonyhallett/ask-toolkit-for-vscode/blob/fix-closed-issue-227/test/askContainer/commands/deviceRegistry.test.ts

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed
[x] My commit message follows Conventional Commit Guideline

License

[x] By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tydonelson commented 1 year ago

Thanks for much for the fix @tonyhallett ! Sorry for the confusion, we had closed the other issue in favor to indicate the the presence of the workaround to resolve the immediate issue and were tracking the underlying issue elsewhere, which wasn't readily apparent here. I just pulled down your change and verified it, looks great!