fix: skill simulation locale drop down was not handling missing IM - Githubissues

alexa / ask-toolkit-for-vscode

ASK Toolkit is an extension for Visual Studio Code (VSC) that that makes it easier for developers to develop and deploy Alexa Skills.

https://developer.amazon.com/en-US/docs/alexa/ask-toolkit/get-started-with-the-ask-toolkit-for-visual-studio-code.html

Apache License 2.0

108 stars 52 forks source link

fix: skill simulation locale drop down was not handling missing IM #260

Closed doiron closed 1 year ago

doiron commented 1 year ago

Description

this commit is the fix https://github.com/alexa/ask-toolkit-for-vscode/commit/eab6d354352abea31a43a577565fcd9a6ae2992f

the other commit, https://github.com/alexa/ask-toolkit-for-vscode/commit/eab6d354352abea31a43a577565fcd9a6ae2992f, which is most of the changes in this PR are mostly trying to improve the file's lint errors (from 23 down to 4)

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[X] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[X] I have read the README document
[ ] I have added tests to cover my changes
[X] All new and existing tests passed
[X] My commit message follows Conventional Commit Guideline

License

[X] By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.