alexadam / save-as-ebook

Save a web page/selection as an eBook (.epub format) - a Chrome/Firefox/Opera Web Extension
MIT License
1.1k stars 70 forks source link

br tag disappears from inside pre tags #36

Open bunglegrind opened 4 years ago

bunglegrind commented 4 years ago

I'm trying to convert the Wordpress Plugin Handbook in epub.

I'm noticing several issues, I'm currently investigating on the causes.

I set a custom style with the following rules:

#wpadminbar {
    display:none;
}
#wporg-header {
    display:none;
}
header {
    display:none;
}
#secondary {
    display:none;
}
#wporg-footer {
    display:none;
}
.breadcrumbs {
    display:none;
}
.nav-links {
    display:none;
}
.table-of-contents {
    display:none;
}
.toc-jump {
    display:none;
}
#content {
    max-width:100%!important;
}
.screen-reader-text {
    display:none;
}

But if I convert this page:

https://developer.wordpress.org/plugins/plugin-basics/determining-plugin-and-content-directories/

the br inside the pre tags are removed showing all the content in the same line...

alexadam commented 4 years ago

this issue should be fixed in the next release (probably next week). You can try it now by manually installing the ext. from the repository.

bunglegrind commented 4 years ago

Yep! It works! Thanks