search

alexadam / save-as-ebook

Save a web page/selection as an eBook (.epub format) - a Chrome/Firefox/Opera Web Extension
MIT License
1.1k stars 70 forks source link

Fails on pages loaded before the extension was installed #39

Open johnhorner opened 4 years ago

johnhorner commented 4 years ago

This is probably an edge case but I had a few pages opened in tabs, then added the extension.

It fails with no obvious message in the UI but this in the console:

Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.

I needed to reload the pages before it worked. I don't know if you can code around this but maybe you can document it?

alexadam commented 4 years ago

do you use Firefox of Chrome? On FF, sometimes. for big pages I have to refresh the page and then retry because it does not work on the first try.

JavierGelatti commented 3 years ago

+1 to this!

I installed the extension and tried to use it on a webpage that was already loaded. First I selected "Save page" and nothing happened, and I couldn't see anything on the browser console either. Then, I tried clicking on "Edit chapters", and this error popped up in the console:

Uncaught ReferenceError: getEbookTitle is not defined
    at showEditor (VM40 chapterEditor.js:50)
    at VM40 chapterEditor.js:9

After finding this issue, I tried reloading the page I wanted to save, and everything worked fine.

I'm using Chrome 87.0.4280.88 (64-bit) on Linux.

Cwpute commented 11 months ago

As a potential and quick workaround for now, you might want to open a new tab or toast message on a first install to greet new users and tell them the currently loaded pages need reloading in order for the extension to work. Additionally, any failed epub conversion might show a message to the user saying it failed, prompting it to retry after having reloaded the page.