search

alexadam / save-as-ebook

Save a web page/selection as an eBook (.epub format) - a Chrome/Firefox/Opera Web Extension
MIT License
1.1k stars 70 forks source link

replacing iframes with divs - issue concerning inline styles #52

Open bunglegrind opened 3 years ago

bunglegrind commented 3 years ago

In https://github.com/alexadam/save-as-ebook/blob/12a4cbb0813742a9617e30e73497f8cd9e403c41/web-extension/extractHtml.js#L120

you're converting iframes to divs. The problem is, if an iframe has a style node, you're applying this style to the whole page.