search

alexadam / save-as-ebook

Save a web page/selection as an eBook (.epub format) - a Chrome/Firefox/Opera Web Extension
MIT License
1.1k stars 70 forks source link

Website pictures are not included on the protected websites #68

Open alarmatwork opened 11 months ago

alarmatwork commented 11 months ago

It seems like pictures are processed as a part of webpage for wikipedia, but they are not included when you try to grab password protected New Scientist article to read on the Kindle. I can see that images are pointed to src="../images/img-2834563815.jpeg"

but for some reason the images are not downloaded, even I probably have auth session present on the page, when the extensions is running.

Is there anything else I can do helping to fix or debug this issue?

Thanks for making such a useful extension!

alexadam commented 11 months ago

You can try to download the extension from github and load it in Firefox or Chrome in dev. mode. Maybe there are some errors in the debugging console (I doubt it since that console is almost useless)

It might be because the request to download the image doesn't have the auth token / session, when it comes from the extension.

I'm planning a new release with bug fixes and better ways to extract info. I'll let you know if I find something.

alarmatwork commented 11 months ago

Probably that's the reason.. I guess images are also protected with auth/session token. It would be probably good idea to make these requests too with the token present.