search

alexadhy / tokyonight-jetbrains

Tokyo Night theme ported from enkia's VSCode Tokyo Night theme
https://plugins.jetbrains.com/plugin/18820-tokyo-night-theme
58 stars 29 forks source link

Difference with Grafikart/tokyo-night-jetbrains-theme #1

Closed Grafikart closed 2 years ago

Grafikart commented 2 years ago

Hi,

I'm also a fan of tokyo night and I already created a port for Jetbrains IDE (https://github.com/Grafikart/tokyo-night-jetbrains-theme). It could be nice to indicates the difference between the two to help user choose the best fit. From my understanding your is more focus on kotlin right ? (I ask this so I can adapt my README and redirect users to your version)

alexadhy commented 2 years ago

I think the only difference between yours and mine is mine includes UI theme in it, without relying on material ui theme so nothing major, I took inspiration from your theme as well.

alexadhy commented 2 years ago

Included links to your port: https://github.com/alexadhy/tokyonight-jetbrains/commit/2bd1415fe621217ee608e06fe1ff0ded990b0104

Grafikart commented 2 years ago

Oh love the fact you included the theme UI. When I have some time i'll try to do a PR for PHP / JS / Twig ... and i'll redirect my plugin to yours since it's more complete. Thanks

You have a process while developping on the plugin to iterate faster ?

alexadhy commented 2 years ago

Basically what I do for UI theme is to use their UI Inspector, and to iterate faster, I'm using gradle based workflow, so testing is done in a clean IDE spawned by gradle.