search

alexalok / dotAPNS

dotAPNS is a library used to send push notifications to Apple devices using Apple Push Notification service via HTTP/2 API.
Apache License 2.0
114 stars 34 forks source link

Replaces old Newtonsoft Json with System.Text.Json and replaces XUnit with MSTest v2 #101

Closed emorell96 closed 2 years ago

emorell96 commented 2 years ago

Adds net6.0, net5.0 as target frameworks to update this to the latest .net Brings nullable from c# 8.0.

Removes net46 support since it's incompatible with System.Text.Json.

I actually wanted to merge this into my own repo, but now that I've opened this draft in here by mistake, you might as well check it out. I am trying to modernize the code a little.

Keeping .Net46 is possible with enough patience doing #if and keeping the old Newtonsoft.Json only for net46. But this change is quite big that it might be worth it to break compatibility?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.