search

alexalouit / ISPConfig-letsencrypt

Let's Encrypt support for ISPConfig
68 stars 23 forks source link

Update existing certificate (adding subdomains) #54

Open s-berney opened 8 years ago

s-berney commented 8 years ago

To be able to update existing certificate, you can add this :

if(file_exists($crt_tmp_file) OR file_exists($key_tmp_file)) {
   $this->_exec("/root/.local/share/letsencrypt/bin/letsencrypt auth --expand --quiet -a webroot --email postmaster@$domain --domains $lddomain --webroot-path $webroot");
}

After the block (line 1017-1036) :

//* check if we have already a Let's Encrypt cert
if(!file_exists($crt_tmp_file) && !file_exists($key_tmp_file)) {
    $app->log("Create Let's Encrypt SSL Cert for: $domain", LOGLEVEL_DEBUG);
    ...
    $this->_exec("/root/.local/share/letsencrypt/bin/letsencrypt auth -a webroot --email postmaster@$domain --domains $lddomain --webroot-path $webroot");
};
[apache2_plugin.inc.php.zip](https://github.com/alexalouit/ISPConfig-letsencrypt/files/317269/apache2_plugin.inc.php.zip)

/* ADD IT HERE */

This command will expand current certificate - and with "quiet" argument, will prevent getting error if the new certificate is identical to existing one ;-)

alexalouit commented 8 years ago

Hi,

Certificates refresh management has been improved since (from let's encrypt). It was already planned, I think it is necessary to let LE manage their certificates.