search

alexames / DeltaBot

GNU General Public License v3.0
65 stars 18 forks source link

Wiki list ordering (Snorrrlax request) #22

Closed PixelOrange closed 10 years ago

PixelOrange commented 10 years ago

Another small style change. It currently looks like this:

Determinism requires faith. CMV. (1)

I think Robin Thicke's Blurred Lines is rape-y and sexist. CMV (1)

Could it look like this instead:

I added another link in the first one to show what the sub-list would look like. Thoughts?

randomPoison commented 10 years ago

If you want the awarded deltas in the ordered list to be listed from newest to oldest, I can throw this together as soon as my pending request is done. If you want the newest ones on the bottom then it'll take more work, but I should still be able to figure it out.

PixelOrange commented 10 years ago

I don't think order is important, but we should include a time stamp. "Awarded by Snorrrlax on 10/07/2013"

Snorrrlax commented 10 years ago

Order isn't that important, but I suppose it would make more sense to have newest underneath, i.e first delta awarded is number 1, second delta awarded is number 2.

randomPoison commented 10 years ago

The timestamp is a nice improvement for record keeping, and I can easily change the list types, so I'll take care of those now. As for ordering deltas oldest-to-newest, that'll take a more complex regex, something a little beyond my current understanding, so I'll fiddle around with that until I find something that works (it shouldn't be too hard, no longer than a few days).

Snorrrlax commented 10 years ago

Oh, I just remembered something that was suggested not long ago.

Can we change this sentence:

/u/%s has received deltas for the following comments:

to this:

/u/%s has received x deltas due to the following comments:

Where x is the number of deltas they have in total.

randomPoison commented 10 years ago

Doable, but it presents the issue of having to retrofit all the previously assembled wiki pages. I would put this into a clean-up script along with the new wiki formatting. In the meantime, I can add it to the code in a way that won't break the rest of the formatting.

PixelOrange commented 10 years ago

Make sure you pull the recent changes before you do. I updated wiki code earlier and it will conflict with this if you don't.

Snorrrlax commented 10 years ago

I noticed another formatting problem, see here:

http://www.reddit.com/r/changemyview/wiki/davinox

It looks like there's just an unnecessary space between the two points. Also, I noticed the number is 1 for both. This doesn't matter when the list is working as reddit automatically orders them, but I thought I'd mention it just in case it cause any other problems.

PixelOrange commented 10 years ago

I thought I fixed that in the latest code update. Do you know when this page was last edited?

On Oct 8, 2013, at 3:58 AM, Snorrrlax notifications@github.com wrote:

I noticed another formatting problem, see here:

http://www.reddit.com/r/changemyview/wiki/davinox

It looks like there's just an unnecessary space between the two points. Also, I noticed the number is 1 for both. This doesn't matter when the list is working as reddit automatically orders them, but I thought I'd mention it just in case it cause any other problems.

— Reply to this email directly or view it on GitHub.

Snorrrlax commented 10 years ago

6 hours ago.

PixelOrange commented 10 years ago

Yeah then it's working. The line that looks weird was before my change, the line that is correctly indented is from my change. We just need to do cleanup on any pages that got edited between those two changes.

On Oct 8, 2013, at 7:27 AM, Snorrrlax notifications@github.com wrote:

6 hours ago.

— Reply to this email directly or view it on GitHub.

PixelOrange commented 10 years ago

Confirmation that this is working as intended: http://www.reddit.com/r/changemyview/wiki/makeyoufeel

PixelOrange commented 10 years ago

Remaining feature requests for this issue:

Snorrrlax commented 10 years ago

On top of what PixelOrange has said, I just have a couple of observations.

  1. The newest links (i.e "I believe men shouldn't be expected to put the toilet seat down for women. CMV (7)", not the sub-list of deltas awarded), are being put underneath when they should be put on top (unlike the sub-list, which would be preferable as newest underneath.)
  2. Usernames on wiki-pages don't show the correct casing. This isn't a big deal really, but in this wiki page, the users /u/KayJoRum and /u/Internomer are having their usernames displayed in lower case.
PixelOrange commented 10 years ago

I'm not sure how I feel about 1. With dates already listed, it just seems like appending to the bottom is the simplest way to handle this. Plus, when you look at a historical reference or timeline, it goes oldest to newest. Newest to oldest is usually reserved for changelogs.

2 is a result of how we handle delta tracking. Python is case sensitive. If you don't force everything to lowercase (or uppercase) it causes our tracking systems to fail. I've even had it fail when I had it check for my name on the site (listed as PixelOrange) and I had it typed into the program (as PixelOrange).

Anyway, the easiest way to fix it would be to bypass the tracking and either pull the name from the API a second time or use a secondary variable to hold the name in its actual case form.

Snorrrlax commented 10 years ago

My thoughts on 1 were if someone wanted to check their own history, they'd see the most recent delta-earning-comment first to save from having to scroll down, and for other people they'd be able to gauge how active that user is by how recent their top link is, if that makes sense. Also, if someone was to earn their first delta in a thread about something particularly offensive, they wouldnt have to see "I think murder is good. CMV.", for example, at the top of their wiki page every time. In another sense, it just adds variety and a sense of activity.

Fixing 2 might be worth looking into once everything else is done, just from a perfectionists' point of view. It's certainly not worth worrying about though.

PixelOrange commented 10 years ago

I was able to fix the wiki-pages casing. The link will always show lowercase (wiki/snorrrlax). This is a reddit limitation. I even tried hardcoding capital letters and it was a no go, but it'll show up correctly in the wiki pages themselves.

PixelOrange commented 10 years ago

Closed due to issue #58