search

alexames / DeltaBot

GNU General Public License v3.0
65 stars 18 forks source link

Updates wiki formatting to include timestamp and ordered list #25

Closed randomPoison closed 10 years ago

randomPoison commented 10 years ago

This addresses most of the changes requested in issue #22: the submissions are now a top-level unordered list, deltas awarded are nested ordered lists, and the deltas have a date stamp for when they were awarded.

randomPoison commented 10 years ago

BEFORE YOU MERGE THIS REQUEST PLEASE READ

So I made a mistake in this request in that I pushed another unrelated commit before this request was accepted. As a consequence, this merge request includes code to fix an issue I found with send_first_time_message.

Commit 2f59b71 added some broken code to adjust_point_flair and send_first_time_message. Line 211 refers to non-existing variable comment, and line 212 does not call send_first_time_message on self.

To fix this, I traced the redditor variable that's passed into adjust_point_flair and found that it is always a string with the redditor's username, so I simply passed it to send_first_time_message, which I changed to accept the redditor's name directly (rather than an object representing the redditor).

If I made a mistake in my interpretation of the code and the current code works, let me know and I'll revert my fork to remove these changes so this merge can be done without adverse side effects.

PixelOrange commented 10 years ago

From what I can tell, this looks good.