search

alexames / DeltaBot

GNU General Public License v3.0
65 stars 18 forks source link

Old Pull Request - Ignore #41

Closed Pluckerpluck closed 10 years ago

Pluckerpluck commented 10 years ago

Due to potential changes... please don't pull this (at least not yet)

If you pull this into live remember to change your config file

This will cause DeltaBot to check to see if a comment was written by the submissions author (OP has replied). If they have AND the no_replies_flair is the current flair then it shall be removed.

This is the first step to potentially using this system. The next step would be to have some way to flair submissions older than a particular ages (the easiest being 0 seconds old). This is a bit more complex to add and I don't have too much time right now.

As long as no_replies_flair is set to something unused in the config then this change should do nothing and can sit idly until this is used.

I thought I'd send the pull request now though ... to get the ball rolling.

Edit: I've realized that my double if statement can be changed to and "if and" statement. That's more preference than anything else.

amorde commented 10 years ago

So what else needs to be done regarding this feature? This seems pretty complete to me unless I am missing something.

Pluckerpluck commented 10 years ago

Oh it's missing a lot. I'd now suggest not pulling this change. The functionality they want to accomplish would probably be achieved in a different way than is being done here.

https://github.com/alexames/DeltaBot/issues/6

The issue is found here.