search

alexander-pick / MKMTool

MKMTool ist a helper application I wrote for tinkering around with optimization of sale processes on magiccardmarket.eu and the idea of automisation of some tasks most people wouldn’t be able to get done by pure manpower.
GNU Affero General Public License v3.0
65 stars 15 forks source link

rocky changes inkl min rare and foil prices and actual buyer list #32

Closed roxart closed 3 years ago

roxart commented 4 years ago

I added a function that gives the actual information about all payed orders (i use it to import into post.ch to directly stamp)

i also added some minor tweaks to the log (show only >2.5€ changes - i guess we can make that better visible in the settings but i didnt do that yet)

Added minprice for all cards (I dont search any card under 0.2€ - got too lazy for that) added minprice for foils

let me know what you think

tomasjanak commented 4 years ago

Hi,

issues I have with this:

The "significant price change" limit for logging (2.5€) should be in the GUI, without it it will be confusing for people used to seeing the log. I could see adding a textbox next to the "Log updates with significant price change" checkbox and allow the user to set the value there. But hardcoded like this I would reject it.

Why did you add the "priceDif > 0" on line 820 of MKMBot.cs? That would make the high variance be passed only for our price being too high, but not for being too low, that quite significantly changes the behaviour. If that is for some reason desirable, it needs to be documented and probably be an option in the GUI. Or am I missing something?

The defaults should stay the same, so keep it at 0 for the foil card and non-rare cards and don't change the default that was there (0.15 for rares). There is no reason to break backwards compatibility for this, who wants to change it will easily change it themselves.

Some short documentation for the new feature would be good (in the README.md). There is also some test code (I presume) that is still active - it looks for Ultimate Masters booster boxes, that should be just deleted, right?

tomasjanak commented 3 years ago

I will close this request since a lot has changed on master and the remarks I had earlier were not addressed, but if you want to add the buyer info I am definitely open to it, so if you merge it onto post-0.8. version I will look at it again, I can help a little with it as well. As for the min price, I think it can already be done with the tools we already have in myStock. The "log only large price changes" with a custom limit is nice, but basically it's already there, just needs a gui to set the limit, now it just uses the "min price rare"...so rather than doing a brand new setting for it, I would just modify the existing one to have a custom number assigned from somewhere.