search

alexander-pick / MKMTool

MKMTool ist a helper application I wrote for tinkering around with optimization of sale processes on magiccardmarket.eu and the idea of automisation of some tasks most people wouldn’t be able to get done by pure manpower.
GNU Affero General Public License v3.0
65 stars 15 forks source link

API request limits ? #42

Closed Deedoo34 closed 3 years ago

Deedoo34 commented 3 years ago

Hello,

First ,already mentionned by a lot of users, but still need to say it : what a great work here you've done ! ;) Need to take time to understand but really helpfull (a lot more when I use a scan app to get list of cards, even I need to reformat the file ^^)

MkM just updated their "API rules" and, if I well understand, we still have a 500O requests per day and now an additonal limit of 600 requests per 60 seconds... Is there a way to manage this in MkMTool ? How can we ensure a "stop" if too many requests done at a time ? (and without splitting a file to import) We will have problems to update our stock this way ! :(

Any idea ?

Thanks for help !

David

tomasjanak commented 3 years ago

Hello, the limiting to 600 requests per minute has already been implemented on the "experimental" branch (https://github.com/alexander-pick/MKMTool/tree/0.8_candidate), it should get out of the experimental status next week. But you can already use it if you want to, the limiting should work correctly there.

Deedoo34 commented 3 years ago

Too fast too furious !!! ^^ Thanks a lot for your answer... and reactivity, I'll try the experimental branch so. Thanks again ;)

tomasjanak commented 3 years ago

Automatic limiter added in commit https://github.com/alexander-pick/MKMTool/commit/dc91a01aca6c5820fdc390f2a2b70f8a9f6b9b42 (available in version 0.8.0.0 or newer)