search

alexander-pick / MKMTool

MKMTool ist a helper application I wrote for tinkering around with optimization of sale processes on magiccardmarket.eu and the idea of automisation of some tasks most people wouldn’t be able to get done by pure manpower.
GNU Affero General Public License v3.0
65 stars 15 forks source link

Making UseStockGetFile "true" gives me a 429 error #66

Closed bombehjort closed 7 months ago

bombehjort commented 9 months ago

Whenever i try to update prices or view inventory, it only works when i have UseStockGetFile "false". or else i get a 429 error. Any fixes? I only want to work with magic cards, and the "games" setting don't work if UseStockGetFile is false.

tomasjanak commented 9 months ago

429 is Too Many Requests. If you still have requests left (they are shown at the bottom of MKMTool as "Api requests made/allowed"), then it must be some error or wrong response code on their part, so you would need to contact the support and tell them that you get that response for GET https://api.cardmarket.com/ws/v2.0/stock/file?idGame=1

bombehjort commented 9 months ago

Bit of an update here: Even running the update with UseStockGetFile "false" gets me errors. It doesn't get a 429 error, but pops up 400 errors for all the cards, including the magic cards. MKMTool 400 errors

tomasjanak commented 7 months ago

I think if you reduce ArticleCountFetched in your config file to 100 or less it should be ok. There have been a change in the API that articles have to be fetched in batches of at most 100, used to be 1000. I will publish a fix later that allows more (up to 1000), but it also means that there is 1 API request for each 100

tomasjanak commented 7 months ago

Fixed in https://github.com/alexander-pick/MKMTool/commit/656e1fdfd03b14ce2422f3c375f73baaade844c4