search

alexander-pick / MKMTool

MKMTool ist a helper application I wrote for tinkering around with optimization of sale processes on magiccardmarket.eu and the idea of automisation of some tasks most people wouldn’t be able to get done by pure manpower.
GNU Affero General Public License v3.0
65 stars 15 forks source link

Fix endpoint url and throttling limits for stock requests #7

Closed friscoMad closed 5 years ago

friscoMad commented 5 years ago

Updates endpoint to the new one (as per documentation it shouldn't be working since august). Also changes the stock calls to limit them to 100 elements and get all elements as requests without limits are getting a 307 redirection that fails (due to the need of a new auth header) when there are more than 1000 elements in your inventory (https://www.mkmapi.eu/ws/documentation/API_2.0:Response_Codes#307_Temporary_Redirect). This is pretty stupid as pagination parameters do not work in stock call so you are limited to get 100 elements per request. Not sure if everything works as it should if your inventory has exactly a multple of 100.

tomasjanak commented 5 years ago

I've made a new pull request (https://github.com/alexander-pick/MKMTool/pull/9) that fixes yet more new limits introduced into the API lately. Since the merge of this and what I did was a bit complicated I did it myself by hand, so everything in this PR is already included in mine. So if my PR is approved, this one should be rejected.

alexander-pick commented 5 years ago

Closed due to the more complete pull from tomas. Thanks to both of you for your contribution!