search

alexander-stannat / Incremental-Pagerank

An implementation of the Monte Carlo method for incremental PageRanks in the Tribler network
6 stars 0 forks source link

Readability #1

Open vandenheuvel opened 5 years ago

vandenheuvel commented 5 years ago

Your notebook looks pretty good, content wise. Could you make sure that all math renders correctly, and that there is no useless output in the document? Then form will improve quite a bit, with minimal effort.

alexander-stannat commented 5 years ago

The notebook has been updated. All code is now running. All links have been fixed and the latex commands now work too. Let me know if you still find anything that needs updating.

alexander-stannat commented 5 years ago

Ref repo cleanup. I have removed most unnecessary files in my repo. For some reason I can't remove the sypy file. That's something I added to check the sybil resistance of incremental pagerank. However I ended up not using it. It seems to be empty, but when I try to remove it the rm -r "sypy" command returns the error message

"fatal: could not lookup name for submodule 'sypy'"

Don't quite know what to do about that. I'll consult Martijn and/or Quinten on Monday about this. Should I keep the .idea and . gitattributes files? Also, I'm not sure what to do with the image files. Is there anyway I can "hide" these as they're not really relevant.

vandenheuvel commented 5 years ago

Remove the .idea/ files, as well as the .gitattributes files. The images are output, and should be generated in notebooks from now on, so remove them or, if they're sufficiently important, generate them from a notebook and commit that.