search

alexander-yakushev / compliment

Clojure completion library that you deserve
Eclipse Public License 1.0
355 stars 38 forks source link

Add passing tests for #58 #103

Closed vemv closed 1 year ago

vemv commented 1 year ago

Brings https://github.com/alexander-yakushev/compliment/pull/102 in again

Green this time by removing the extraneous test

image

Cheers - V

alexander-yakushev commented 1 year ago

These test cases are redundant without that failing test. Filtering by the type of a global var is already tested here https://github.com/alexander-yakushev/compliment/blob/master/test/compliment/sources/t_class_members.clj#L73. And the last testcase just shows the baseline behavior; besides, the message says it has something to do with the constructor not being package-qualified while currently it doesn't matter at all.

I don't think these tests are needed unless and until you implement the extension to class resolution logic.

vemv commented 1 year ago

Thanks for the analysis!

Let's leave it then. I have something more interesting around the corner 👀