search

alexander-yakushev / compliment

Clojure completion library that you deserve
Eclipse Public License 1.0
355 stars 38 forks source link

Add reader conditional support #116

Closed JJ-Atkinson closed 7 months ago

JJ-Atkinson commented 9 months ago

And a couple other changes.

JJ-Atkinson commented 9 months ago

Sweet, I think it's all sorted out

JJ-Atkinson commented 9 months ago

Thanks for moving to deps.edn btw - it's a great help!

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (41ac6c1) 94.73% compared to head (39c8f98) 94.74%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #116 +/- ## ========================================== + Coverage 94.73% 94.74% +0.01% ========================================== Files 12 12 Lines 854 856 +2 Branches 30 30 ========================================== + Hits 809 811 +2 Misses 15 15 Partials 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JJ-Atkinson commented 7 months ago

@alexander-yakushev anything else that I should look into fixing on this PR? I don't mean to be a nag but I'm hoping to release some code depending on this soon.

alexander-yakushev commented 7 months ago

I am sorry, I forgot that this is ready to go. Thanks for the contribution!

JJ-Atkinson commented 7 months ago

no problem - thanks!