Closed vmfhrmfoaj closed 2 years ago
@vemv Fixed, thank you for review.
@vmfhrmfoaj Your changes look to good to me. Can you also mention them in the changelog, please?
@bbatsov I updated.
Thanks for accurately satisfying all suggestions!
@vmfhrmfoaj Can you also rebase on top master
to resolve the conflict in the changelog?
Thanks!
First of all, thank you for developing and maintaining 'compliment'. I found problems related to namespaced keywords:
compliment.context/try-read-replacing-maps
returnnil
if aliased namespace keywords(e.g.::my-ns/keyword
) are contained in context string. (read-str
try to resolve the alias) I changedtry-read-replacing-maps
to replace aliased namespace keyword to namespaced keyword(e.g.:my-ns/keyword
) to avoid the problem.compliment.sources.local-bindings/parse-binding
ignore variables that destructuring the map with namespaced keywords:I changed
parse-binding
to handle namespaced keywords.