alexanderGugel / ied

:package: Like npm, but faster - an alternative package manager for Node
http://alexandergugel.github.io/ied
MIT License
1.99k stars 53 forks source link

Replace per module download progress with progress reporting over the whole process #108

Closed rase- closed 8 years ago

rase- commented 8 years ago

Shows progress similarly to how webpack does, and shows it for the whole installation process instead of individual dependencies. Looks like this:

patch

Doesn't look like it affects permformance very radically. I'm looking at a difference between

ied i  1.44s user 0.37s system 80% cpu 2.253 total

and

ied i  1.11s user 0.27s system 57% cpu 2.393 total

In short, it's implemented so that for every module we resolve we increment the total amount we need to install. For every resolved local module or fetched module we increment the count for modules that are ready. This is abstracted by .total and .tick() in the progress package. It also provides the formatting we use to display progress.

rase- commented 8 years ago

The above tests were actually ran againts the old rebirth branch commit without the current progress reporting per download. I can rerun a diff with the current reporting a bit later, too.

alexanderGugel commented 8 years ago

LGTM