alexanderGugel / ied

:package: Like npm, but faster - an alternative package manager for Node
http://alexandergugel.github.io/ied
MIT License
1.99k stars 53 forks source link

Fix build for specific npm-related edge cases #134

Closed mgcrea closed 8 years ago

mgcrea commented 8 years ago
Checklist

Build

Description of change

Added support for dtrace-provider@0.6.0 build.

mgcrea commented 8 years ago

I've added an extra commit to this PR that fixed many builds when trying on a complex package.json from a modern react app. Basically all builds are now run serially. That prevents race conditions that would make the builds fail most of the time when several builds where run in parallel.

alexanderGugel commented 8 years ago

Uh, that's interesting. Does the order in which we build the packages matter?

mgcrea commented 8 years ago

@alexanderGugel I don't think the order matters, I encountered mostly file missing errors that would not happen when I installed+build packages one by one. I guess node-gyp does not like being run in parallel.

mgcrea commented 8 years ago

By the way, I think we should build by default (and maybe add an option to skip builds), having non working setups after an ied i feels a bit clunky.