search

alexanderGugel / ied

:package: Like npm, but faster - an alternative package manager for Node
http://alexandergugel.github.io/ied
MIT License
1.99k stars 53 forks source link

Refactor eslint #139

Closed mgcrea closed 8 years ago

mgcrea commented 8 years ago

Following #138 with only eslint related changes.

Thanks for the review, indeed some changes are cosmetic, and a matter of state, I don't really mind about any of them, a few side-notes:

  • regarding forEach instead of for of, I'm not encountering for of in most of the code I'm looking into so I'm not "used to it", forEach is shorter of both 1 LOC and 1 variable definition so it looks like a little bit more simple/elegant to me but I'll gladly revert it if you want.
  • regarding balanced spacing in params, I tried to go for the rule that enforced the least changes. But usually the related eslint-rules are object-curly-spacing and array-bracket-spacing, so one issue with the code was that import statements did not respect curly-spacing ever, and it was mixed for inline objects.
mgcrea commented 8 years ago

Replaced by #138.