Fix and properly test both `file:` and `github:` targets

alexanderGugel / ied

:package: Like npm, but faster - an alternative package manager for Node

http://alexandergugel.github.io/ied

MIT License

1.99k stars 53 forks source link

Fix and properly test both `file:` and `github:` targets #142

Closed mgcrea closed 8 years ago

mgcrea commented 8 years ago

Checklist

[X] tests and code linting passes
[X] a test is included
[X] the commit message follows commit guidelines
Affected core subsystem(s)

install

Description of change

Fixed wrong url.resolve usage in github: resolve
Added unit tests for both file: and github: targets.
Improve NPM scripts for easier development workflow

alexanderGugel commented 8 years ago

Awesome! Great stuff. Now that we have this part tested as well, I think it's safe to release it.

I'm going to cut v2.1.0 this weekend, which will include support for git dependencies and local file:// installs.

mgcrea commented 8 years ago

@alexanderGugel I have a couple more tests/fixes coming (support for bitbucket, etc.) so don't release just yet! (or we can always land a patch release after...)

alexanderGugel commented 8 years ago

@mgcrea Ok, sounds great! I don't think it's a huge issue to release it either way. The code is really solid and - as you said - we can always release a patch.

alexanderGugel / ied

Fix and properly test both `file:` and `github:` targets #142

Checklist

Affected core subsystem(s)

Description of change