alexanderGugel / ied

:package: Like npm, but faster - an alternative package manager for Node
http://alexandergugel.github.io/ied
MIT License
1.99k stars 53 forks source link

IED installer with phantomJS or with phantomjs-prebuilt #198

Open tigran1997 opened 7 years ago

tigran1997 commented 7 years ago

Ied installer which installs parallel sub-dependencies have an issue with phantomjs/pahtnomjs-prebuilt. Problem is that custom npm installer install's package with phantomjs (downloads from github if it does not exist in pc/virtual machine) and sets the path of it in location.js in lib folder which also not exists due to ied installer. You can view it on lib/phantomjs.js file

try {
  var location = require('./location')
  exports.path = path.resolve(__dirname, location.location)
  exports.platform = location.platform
  exports.arch = location.arch
} catch(e) {
  // Must be running inside install script.
  exports.path = null
}

@alexanderGugel please review this. You can view it also in StackOverflow https://stackoverflow.com/questions/45031555/ied-installer-with-phantomjs-phantomjs-prebuilt

henryruhs commented 7 years ago

Hey @alexanderGugel ,

I had trouble using IED to install phantom-node / phantomjs-prebuilt on Travis CI. Finally, I switched back to npm install over ied install.

Broken build: https://travis-ci.org/redaxmedia/ncss-linter/builds/260420721 Passed build: https://travis-ci.org/redaxmedia/ncss-linter/builds/260421164

Best regards Henry