Closed alexanderGugel closed 8 years ago
Well, that gives some boost up for the most common way, when you install everything from NPM registry.
I couldn't do it in a nice way, so I did it as it is now. If you have an idea how to make it better, I will be happy to know it.
I'm currently working on a refactor as we speak. I'm going to make a "Transaction" class that basically just has an EventEmitter used for coordinating installs. I think that should make it simpler to implement.
Done.
This was the original behavior, but it changed when we started supporting downloads.
The part in question is the
recurse
function:Instead of reading the
package.json
once we downloaded a dependency, we should use thepackage.json
file (and the contained dependencies) that we get from the registry. The above logic should only be implemented for tarballs. This needs to be changed./cc @just-boris I'm going to have to change this back.