alexanderatallah / window.ai

Use your own AI models on the web
https://windowai.io
MIT License
782 stars 68 forks source link

window.ai call hangs, extension doesn't ask for permission, for Three.js example #69

Closed zoan37 closed 1 year ago

zoan37 commented 1 year ago

This is probably an edge case, but when trying to call window.ai in a Three.js demo example in the Three.js package, the window.ai call hangs, and the extension doesn't show a pop up asking for permission as expected. Confirmed this for the current Window build and the beta build with 3D object generation.

I'm not sure what is special about the Three.js demo that is leading to this behavior.

This is not blocking me because I'm planning to port that demo code to another repo.

Steps to reproduce:

YanniKouloumbis commented 1 year ago

Cloned the repo but I don't see a window_possible_bug branch, is it pushed?

zoan37 commented 1 year ago

@YanniKouloumbis Oh, it is right here: https://github.com/zoan37/three.js/tree/window_possible_bug , hope that works

(btw I ported my code to a new repo with just the octree demo code and it's working there, funny this repo doesn't work)

zoan37 commented 1 year ago

oh I'm getting same error when doing "git checkout window_possible_bug", i'll look into it

zoan37 commented 1 year ago

Sorry, please run:

git checkout -b window_possible_bug
git pull origin window_possible_bug

instead of git checkout window_possible_bug as stated above.

YanniKouloumbis commented 1 year ago

If I run a sample command in the console I see the popup. Is there a way to reproduce the window.ai call?

image
zoan37 commented 1 year ago

I found the issue, the example is displayed in an iframe! lol. sorry for the trouble!

YanniKouloumbis commented 1 year ago

No worries, glad it's all working! Closing this issue!