fixed the meme generator script

alexanderepstein / Bash-Snippets

A collection of small bash scripts for heavy terminal users

MIT License

9.64k stars 842 forks source link

fixed the meme generator script #164

Closed onprem closed 6 years ago

onprem commented 6 years ago

The minor bugs listed in #163 were fixed by

Using .png extension instead of .jpg
Replacing spaces in input line with underscores, using tr (fastest method according to this ).

Pull Request Label:

[x] Bug
[ ] New feature
[ ] Enhancement
[ ] New component
[ ] Typo

Pull Request Checklist:

[x] Have you followed the guidelines for contributing?
[x] Have you checked that there aren't other open pull requests for the same fix or component?
[x] Have you ran the tests locally with bats tests?

onprem commented 6 years ago

fixed #163

alexanderepstein commented 6 years ago

Hey, sorry I haven't been able to answer this but before I merge I want to understand why some of the tests are failing. When I am able to I will take a further look into it

onprem commented 6 years ago

I was wondering the same about the tests. Also I appreciate your looking into it.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

alexanderepstein commented 6 years ago

Not stale still looking into this, been busy with finals

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 6 years ago

This issue has been automatically closed because it has been inactive for 30 days.