Closed virgilwashere closed 5 years ago
Pull Request Label:
Pull Request Checklist:
bats tests
[x] :white_check_mark: :green_heart: fix shebang in tests/*
tests/*
It was #!/bin/env now #!/usr/bin/env. The travis config masked this by calling bats on the ./tests directory.
#!/bin/env
#!/usr/bin/env
bats
./tests
[x] :bug: :apple: fix bash 3.2 regex comparisons
[x] :penguin: fix bats output checks
Using conditional regex checks: [[ ${output} =~ ${expected} ]]
[[ ${output} =~ ${expected} ]]
[x] :alien: update weather.bats due to external change
weather.bats
wttr returns "Paramus" and not "Paramus, United States of America" as it did previously.
wttr
[x] :speech_balloon: bump version tag in bak2dvd to match repo
bak2dvd
Update would never be satisfied.
[x] :truck: recover cheats.bats
cheats.bats
This was overwritten in 0b291d2. Addresses #184
short.bats
skeleton.bats
bak2dvd.bats
cheat.bats
taste.bats
skeleton
Not all the tests are refactored. skeleton.bats should reduce the effort.
This is awesome, I will be merging these soon once i get the chance to read over them. Thank you for the fixes it really helps as my time has been limited for a while now.
:white_check_mark: updates to tests
Pull Request Label:
Pull Request Checklist:
bats tests
?:ambulance: fixes
[x] :white_check_mark: :green_heart: fix shebang in
tests/*
It was
#!/bin/env
now#!/usr/bin/env
. The travis config masked this by callingbats
on the./tests
directory.[x] :bug: :apple: fix bash 3.2 regex comparisons
[x] :penguin: fix bats output checks
Using conditional regex checks:
[[ ${output} =~ ${expected} ]]
[x] :alien: update
weather.bats
due to external changewttr
returns "Paramus" and not "Paramus, United States of America" as it did previously.[x] :speech_balloon: bump version tag in
bak2dvd
to match repoUpdate would never be satisfied.
[x] :truck: recover
cheats.bats
This was overwritten in 0b291d2. Addresses #184
:sparkles: enchancements
short.bats
skeleton.bats
boilerplate test file:hammer: refactoring
bak2dvd.bats
from new bats skeletoncheat.bats
from new bats skeletonshort.bats
from new bats skeletontaste.bats
from new bats skeletonweather.bats
from new bats skeletonskeleton
Not all the tests are refactored.
skeleton.bats
should reduce the effort.